Skip to content

Commit

Permalink
Add newline after markdown content for GitHub reporting
Browse files Browse the repository at this point in the history
  • Loading branch information
lbarcziova committed Jul 29, 2024
1 parent 07aed21 commit a2548d5
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions packit_service/worker/reporting/reporters/github.py
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ def set_status(
summary = (
self._create_table(url, links_to_external_services)
+ markdown_content
+ "\n"
+ f"---\n*{News.get_sentence()}*"
)

Expand Down
4 changes: 2 additions & 2 deletions tests/unit/test_reporting.py
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ def test_set_status_github_check(
status=check_status,
conclusion=check_conclusion,
output=create_github_check_run_output(
title, summary + "---\n*Interesting news.*"
title, summary + "\n---\n*Interesting news.*"
),
).once()

Expand Down Expand Up @@ -460,7 +460,7 @@ def test_status_instead_check(
status=check_status,
conclusion=check_conclusion,
output=create_github_check_run_output(
title, summary + "---\n*Interesting news.*"
title, summary + "\n---\n*Interesting news.*"
),
).and_raise(exception_type).once()

Expand Down

0 comments on commit a2548d5

Please sign in to comment.