Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assume: Print a friendly error message when no access #24

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

nbrahms
Copy link
Contributor

@nbrahms nbrahms commented Feb 22, 2024

Rather than proxying the AWS error message, display a friendly / useful error message to the user, when they attempt to assume a role to which they do not have access.

Rather than proxying the AWS error message, display a friendly / useful
error message to the user, when they attempt to assume a role to which
they do not have access.
Copy link
Contributor

@GGonryun GGonryun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes make sense to me 👍 .

left a small comment about a type.

src/commands/aws/role.ts Show resolved Hide resolved
@nbrahms nbrahms merged commit 77e650d into main Feb 22, 2024
2 checks passed
@nbrahms nbrahms deleted the nathan/role-assume-error branch April 2, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants