More command tests #23
Conversation
This adds testing for all commands except SSH.
nbrahms
force-pushed
the
nathan/more-tests
branch
from
a15e44c
to
5841f22
Compare
| try { | ||
| await spec.fail((_, err) => (error = err)).parse(command); | ||
| } catch (thrown: any) { | ||
| error = thrown; |
There was a problem hiding this comment.
could this function only returning the thrown error in the catch block instead of defining let error: any at the top?
There was a problem hiding this comment.
No, because the main throw path is via line 6 (TBH one could probably just remove the try / catch altogether; I'll investigate)
src/commands/login.ts
Outdated
| /** Logs in the user | ||
| * | ||
| * Currently only supports login to a single organization. Login credentials, together | ||
| * with organization details, are saved to ~/.p0/identity.json. |
There was a problem hiding this comment.
nit: should we mention that the file path is determined by the variable: IDENTITY_FILE_PATH instead of a hard coded path?
| }); | ||
| }); | ||
| }); | ||
| describe("with Okta SAML", () => { |
There was a problem hiding this comment.
I noticed that we're missing a test here to verify the error No roles found. You have roles on these accounts... which is thrown when we're trying to list roles but the user doesn't have any.
p0cli/src/commands/aws/role.ts
Line 128 in 77e650d
We can probably add it later, wdyt?
nbrahms
force-pushed
the
nathan/more-tests
branch
from
8c65215
to
8584764
Compare
nbrahms
force-pushed
the
nathan/more-tests
branch
from
8584764
to
e755965
Compare
This adds testing for all commands except SSH.