Replace console.foo with helper functions #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows us to: - Intercept these methods at test time - Duplicate output streams (e.g. to a log file)
nbrahms
force-pushed
the
nathan/print
branch
from
c81b3ff
to
e1aa441
Compare
nbrahms
force-pushed
the
nathan/print
branch
from
94db248
to
493c0ed
Compare
komal-dhull
approved these changes
Feb 20, 2024
| * only by humans. | ||
| */ | ||
| export function print1(message: any) { | ||
| // eslint-disable-next-line no-console |
There was a problem hiding this comment.
nit: can we use more descriptive names than print1 and print2?
There was a problem hiding this comment.
I think these are pretty common in the Unix world, as 1 and 2 refer to the respective file descriptors (/fd/1 is stdout, /fd/2 is stderr).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows us to:
Also completely removes unused
permission.tsfile.