Add debugging output for Azure SSH provider #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GGonryun
approved these changes
Nov 22, 2024
p0-andrewa
force-pushed
the
andrewadams/eng-3131-add-azure-ssh-repro-commands
branch
from
6d61bd5
to
287a0d3
Compare
Base automatically changed from
andrewadams/eng-3131-add-azure-ssh-repro-commands
to
main
November 23, 2024 00:35
Adds debugging output for the various Azure CLI (`az`) commands invoked as part of the Azure SSH provider. Also includes a (filtered) debugging output from the Azure Network Bastion tunnel process to aid with debugging that part of the provider.
p0-andrewa
force-pushed
the
andrewadams/eng-3131-azure-ssh-debug-output
branch
from
2dd6b80
to
ecf1b40
Compare
|
Simple rebase on main; will merge when checks are done running. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the Azure SSH debugging experience by adding debug output for the various
azcommands being run before opening thessh/scpsession. Specifically, when the--debugflag is set, the CLI will output the stdout and stderr for all theazcommands it runs. Note though that it won't set the--debugflag for theazcommands themselves as this outputs far too much information, with the exception of theaz network bastion tunnelcommand; while it still outputs far too much information in debug mode, it has an unfortunate tendency to hide certain errors unless you pass it the--debugflag, so I did add it there.Some additional information is also logged by the CLI itself now when the
--debugflag is set.Testing
Tested locally against my Azure VM in our test tenant, both with and without the
--debugflag.Screenshots
Example output when not using
--debug; matches output from before this PR (as before, sensitive redaction value by my terminal, not the CLI):Examples of output when using
--debug:Initial startup:
Generating Azure AD SSH certificate:
Starting tunnel (and showing repro commands added in previous PR):
Closing SSH session and shutting down tunnel:
