Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update ssh command arguments to use shared properties #142

Merged
merged 2 commits into from
Nov 15, 2024
Merged

update ssh command arguments to use shared properties #142

merged 2 commits into from
Nov 15, 2024

Conversation

GGonryun
Copy link
Contributor

This PR updates the ssh command argument account to use the new shared name: parent. The parent argument unifies inputs of accountId for AWS, projectId for Google Cloud, and subscriptionId for Azure.

image

@GGonryun GGonryun marked this pull request as ready for review November 15, 2024 22:27
@GGonryun GGonryun self-assigned this Nov 15, 2024
@GGonryun
Copy link
Contributor Author

https://linear.app/p0-security/issue/ENG-3108/ssh-cli-update-the-ssh-account-property-to-shared-parent-property

p0-andrewa
p0-andrewa approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@p0-andrewa p0-andrewa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one small thing

src/commands/ssh.ts Outdated Show resolved Hide resolved
@GGonryun GGonryun merged commit cfc8d58 into main Nov 15, 2024
3 checks passed
@GGonryun GGonryun deleted the miguelcampos/fix/ssh-command-args branch November 15, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p0-andrewa p0-andrewa p0-andrewa approved these changes

Assignees

@GGonryun GGonryun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GGonryun @p0-andrewa