Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth error logging #13

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Auth error logging #13

merged 1 commit into from
Aug 22, 2023

Conversation

gergas3
Copy link
Contributor

@gergas3 gergas3 commented Aug 21, 2023

Log clientId for better context on errors - we don't know which client is failing when multiple clients/tenants are trying to connect.

@gergas3 gergas3 requested a review from nbrahms August 21, 2023 21:46
nbrahms
nbrahms approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@nbrahms nbrahms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gergas3 gergas3 merged commit ab17771 into main Aug 22, 2023
1 check passed
@gergas3 gergas3 deleted the greg/auth-error-logging branch August 22, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbrahms nbrahms nbrahms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gergas3 @nbrahms