Skip to content

Commit

Permalink
Does it fix MacOS build?
Browse files Browse the repository at this point in the history
  • Loading branch information
ozankaraali committed May 20, 2024
1 parent fa45822 commit d47011a
Show file tree
Hide file tree
Showing 3 changed files with 26 additions and 81 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ jobs:
- name: Package App with PyInstaller for macOS (Intel)
run: |
pip install pyinstaller
pyinstaller qitv-macos-intel.spec
pyinstaller qitv-macos.spec
- name: Ad-Hoc Sign the app
run: |
codesign --force --deep --sign - dist/qitv.app
Expand Down
59 changes: 0 additions & 59 deletions qitv-macos-intel.spec

This file was deleted.

46 changes: 25 additions & 21 deletions qitv-macos.spec
Original file line number Diff line number Diff line change
@@ -1,44 +1,48 @@
import site
import os
# -*- mode: python ; coding: utf-8 -*-

PACKAGES_PATH = site.getsitepackages()[0]
VLC_PATH = '/Applications/VLC.app/Contents/MacOS/lib' # Adjust this path if necessary

block_cipher = None
VLC_PATH = '/Applications/VLC.app/Contents' # Adjust this path if necessary

a = Analysis(
['main.py'],
pathex=[],
pathex=[VLC_PATH],
binaries=[
(os.path.join(VLC_PATH, 'libvlc.dylib'), '.'),
(os.path.join(VLC_PATH, 'libvlccore.dylib'), '.')
],
datas=[
('assets/qitv.icns', 'assets/qitv.icns')
(os.path.join(VLC_PATH, 'MacOS/plugins/*'), 'plugins'),
],
datas=[],
hiddenimports=[],
hookspath=[],
runtime_hooks=[],
excludes=[],
win_no_prefer_redirects=False,
win_private_assemblies=False,
cipher=block_cipher,
noarchive=False
noarchive=False,
#https://github.com/pyinstaller/pyinstaller/issues/7851#issuecomment-1677986648
module_collection_mode={
'vlc': 'py',
}
)
pyz = PYZ(a.pure, a.zipped_data, cipher=block_cipher)

pyz = PYZ(a.pure)

exe = EXE(
pyz,
a.scripts,
a.binaries,
a.zipfiles,
a.binaries, + [
"libvlc.dylib", os.path.join(VLC_PATH, 'MacOS/lib/libvlc.dylib'), "BINARY"),
"libvlccore.dylib", os.path.join(VLC_PATH, 'MacOS/lib/libvlccore.dylib'), "BINARY"),
]
a.datas,
[],
name='qitv',
debug=False,
bootloader_ignore_signals=False,
strip=False,
upx=True,
upx_exclude=[],
runtime_tmpdir=None,
console=False,
icon='assets/qitv.icns'
disable_windowed_traceback=False,
argv_emulation=False,
target_arch=None,
codesign_identity=None,
entitlements_file=None,
)
app = BUNDLE(
exe,
Expand Down

0 comments on commit d47011a

Please sign in to comment.