Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VA] Add Lifetime Capability and Max Expiration Time Info #264

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

sekarlm
Copy link
Contributor

@sekarlm sekarlm commented Sep 21, 2023

[VA] Add Lifetime Capability and Max Expiration Time Info

Copy link

@josephine-oy josephine-oy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sekarlm, kar, boleh tambahin di paling bawah ga, 1 line gitu. intinya bilang no minimum expiration time

@sekarlm
Copy link
Contributor Author

sekarlm commented Sep 21, 2023

@sekarlm, kar, boleh tambahin di paling bawah ga, 1 line gitu. intinya bilang no minimum expiration time

udah ditambahin ya kak @josephine-oy

Copy link

@josephine-oy josephine-oy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks ya kar

| Bank Danamon | 011 | Open Amount, Closed Amount |
| Bank (Virtual Account) | Bank Code | Open & Closed Amount Capability | Lifetime Capability | Maximum Expiration Time |
| ---------------------- | ---------------------------------------------- | ---------------------------------------------- | ---------------------------------------------- | ---------------------------------------------- |
| BNI | 009 | Closed Amount | Supported | - |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yang buat andiarta kan ada open amount, gaperlu distate disini kan ya?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jangann, ntar malah mismatched expectation ke client lain

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc kak @josephine-oy karena BNI open amount khusus buat andiarta aja, ga perlu distate di API Docs kita kan ya?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

itu udah gua jawab kar wkwkwk jangan ditulis, ntar malah mismatched expectation ke client lain

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh maap blm refresh github, baru muncul comment ridho doang wkwk

@sekarlm sekarlm merged commit 1411bbe into master Sep 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants