-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(indexmap): Add support for changing HashMaps to IndexMaps. #708
feat(indexmap): Add support for changing HashMaps to IndexMaps. #708
Conversation
@ahl Would appreciate your input on this before I continue down the TODO list, at least just an affirmation that you're happy with the direction I'm taking this lol. |
I added some notes to #555 |
9807eb4
to
dee9c58
Compare
@ahl I have read and adjusted the PR according to your comments. I believe this is ready for review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good progress! I'd love to see some materialized code akin to the test_schemas
test, but I don't want to duplicate all of that. If you have any ideas please let me know.
I notice that there are quite a few clippy warning in this repo, would you be open to an MR purely resolving lints + adding a CI job to maintain them going forward? |
Had a go at this, let me know if it is what you are after. |
Other: improve documentation & test cases.
38453a9
to
9d23fcf
Compare
9d23fcf
to
f836f36
Compare
I don't think that would be helpful at this time. |
Thanks for the contribution. |
Feature
This MR closes #555, and implements support for generating using
IndexMap
instead ofHashMap
as a global setting.TODO
SupportSets are not yet supported in the wider API.IndexSet
instead ofHashSet
Map
? Any requests while I'm here?