Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(indexmap): Add support for changing HashMaps to IndexMaps. #708

Merged
merged 9 commits into from
Dec 20, 2024

Conversation

JosiahBull
Copy link
Contributor

@JosiahBull JosiahBull commented Dec 3, 2024

Feature

This MR closes #555, and implements support for generating using IndexMap instead of HashMap as a global setting.

TODO

  • Support IndexSet instead of HashSet Sets are not yet supported in the wider API.
  • Support other types of Map? Any requests while I'm here?

@JosiahBull
Copy link
Contributor Author

@ahl Would appreciate your input on this before I continue down the TODO list, at least just an affirmation that you're happy with the direction I'm taking this lol.

@ahl
Copy link
Collaborator

ahl commented Dec 5, 2024

I added some notes to #555

@JosiahBull JosiahBull force-pushed the jo/add-indexmap-support-to-typify branch from 9807eb4 to dee9c58 Compare December 5, 2024 20:33
@JosiahBull JosiahBull marked this pull request as ready for review December 5, 2024 20:36
@JosiahBull
Copy link
Contributor Author

@ahl I have read and adjusted the PR according to your comments. I believe this is ready for review now.

Copy link
Collaborator

@ahl ahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good progress! I'd love to see some materialized code akin to the test_schemas test, but I don't want to duplicate all of that. If you have any ideas please let me know.

typify-impl/src/structs.rs Outdated Show resolved Hide resolved
typify-impl/src/lib.rs Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
typify-impl/src/type_entry.rs Outdated Show resolved Hide resolved
typify-impl/src/type_entry.rs Show resolved Hide resolved
@JosiahBull
Copy link
Contributor Author

I notice that there are quite a few clippy warning in this repo, would you be open to an MR purely resolving lints + adding a CI job to maintain them going forward?

@JosiahBull
Copy link
Contributor Author

I'd love to see some materialized code akin to the test_schemas test

Had a go at this, let me know if it is what you are after.

@JosiahBull JosiahBull force-pushed the jo/add-indexmap-support-to-typify branch 2 times, most recently from 38453a9 to 9d23fcf Compare December 6, 2024 20:43
@JosiahBull JosiahBull force-pushed the jo/add-indexmap-support-to-typify branch from 9d23fcf to f836f36 Compare December 6, 2024 20:45
@JosiahBull JosiahBull requested a review from ahl December 6, 2024 20:45
README.md Outdated Show resolved Hide resolved
typify-impl/src/defaults.rs Outdated Show resolved Hide resolved
typify-impl/src/type_entry.rs Show resolved Hide resolved
typify-impl/src/type_entry.rs Outdated Show resolved Hide resolved
typify-impl/src/lib.rs Outdated Show resolved Hide resolved
@ahl
Copy link
Collaborator

ahl commented Dec 6, 2024

I notice that there are quite a few clippy warning in this repo, would you be open to an MR purely resolving lints + adding a CI job to maintain them going forward?

I don't think that would be helpful at this time.

@JosiahBull JosiahBull requested a review from ahl December 15, 2024 22:32
example.json Show resolved Hide resolved
typify-impl/src/lib.rs Show resolved Hide resolved
@JosiahBull JosiahBull requested a review from ahl December 20, 2024 02:12
@ahl
Copy link
Collaborator

ahl commented Dec 20, 2024

Thanks for the contribution.

@ahl ahl merged commit d2e1757 into oxidecomputer:main Dec 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to generate code with IndexMap instead of HashMap
2 participants