Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tailwind to ts #89

Closed
wants to merge 2 commits into from
Closed

Update tailwind to ts #89

wants to merge 2 commits into from

Conversation

augustuswm
Copy link
Contributor

@augustuswm augustuswm commented Dec 16, 2024

There is still a type error with the @oxide/design-system import. Looking in node_modules I don't see an exported type file. Do we need a design-system version bump?

Copy link

vercel bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rfd-site ✅ Ready (Inspect) Visit Preview Dec 16, 2024 7:04pm

@david-crespo
Copy link
Contributor

Yes, it requires a design-system bump because of oxidecomputer/design-system#97. Unfortunately also bundled in with that release is a change to the color tokens that requires a small but kind of annoying update to the use of Tailwind text color classes everywhere. Example: oxidecomputer/console#2588

I can try to do it, let me see.

@david-crespo
Copy link
Contributor

Oh, it's even worse — @benjaminleonard has to do the whole conversion to the new way asciidoc works. If everything is broken right now I can figure out a workaround that does not require this upgrade.

@augustuswm
Copy link
Contributor Author

I don't think this has to be done this minute / today. The part stuck here is a fix for the inline GitHub discussions. This is definitely less important than any product work.

@benjaminleonard
Copy link
Collaborator

I'm not far off, should have the PR done today or tomorrow.

@benjaminleonard
Copy link
Collaborator

Handled in #95 – and we're back up to LTS node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants