server: add a first-class error type to machine init #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a `MachineInitError` type and make `MachineInitializer` functions return it. This makes it more convenient to handle new logic errors in initializer functions. To handle the (many) cases where the initializer calls bhyve ioctls or filesystem functions that return `std::io:Error`, `MachineInitError` has a catchall `anyhow::Error` variant; this encourages calls that produce I/O errors to call `context` or `with_context` to better describe those errors. Tested by running propolis-server ad hoc in a couple of invalid configurations (file backend not pointing to an actual file; too many vCPUs; more guest memory than the host has available) and verified that the error chains (and contexts, if applicable) show up in the Propolis logs.
iximeow
approved these changes
Oct 2, 2024
| let fwcfg = fwcfg::FwCfg::new(); | ||
| fwcfg | ||
| .insert_legacy( | ||
| fwcfg::LegacyId::SmpCpuCount, | ||
| fwcfg::Entry::fixed_u32(u32::from(cpus)), | ||
| ) | ||
| .unwrap(); | ||
| .map_err(|e| MachineInitError::FwcfgInsertFailed("cpu count", e))?; |
hawkw
approved these changes
Oct 2, 2024
|
Thanks for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
MachineInitErrortype and makeMachineInitializerfunctions return it. This makes it more convenient to handle new logic errors in initializer functions. To handle the (many) cases where the initializer calls bhyve ioctls or filesystem functions that returnstd::io:Error,MachineInitErrorhas a catchallanyhow::Errorvariant; this encourages calls that produce I/O errors to callcontextorwith_contextto better describe those errors.Tested by running propolis-server ad hoc in a couple of invalid configurations (file backend not pointing to an actual file; too many vCPUs; more guest memory than the host has available) and verified that the error chains (and contexts, if applicable) show up in the Propolis logs.