PciPath to Bdf conversion is infallible; prove it and refactor #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iximeow
force-pushed
the
ixi/infallible-pcipath-to-bdf
branch
from
e14253e to
9c64888
Compare
pfmooney
approved these changes
Oct 1, 2024
|
i'd mostly just noticed it didn't "feel slow", but on second look it's 1.87s on a 7950x. so maybe it's more "not slow if you've just also been waiting to rebuild propolis".. |
Seems reasonable enough. If it becomes a problem in the future, we could rub some |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i initially tried to find
TryIntocases by deleting the impl and seeing what broke, but clippy is much better at this than me.cargo xtask clippy, in fact, is something i forgot i can or should run.