bump softnpu #577
Merged
bump softnpu #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcgoodfellow
force-pushed
the
softnpu-bump
branch
from
c978d42 to
d1e2c51
Compare
|
It looks like I should update the |
Perhaps. This is pulling in |
rcgoodfellow
force-pushed
the
softnpu-bump
branch
2 times, most recently
from
9786ad1 to
ff873f3
Compare
rcgoodfellow
force-pushed
the
softnpu-bump
branch
from
ff873f3 to
c2333d1
Compare
rcgoodfellow
force-pushed
the
softnpu-bump
branch
from
56c63c0 to
a11fdd1
Compare
pfmooney
reviewed
Dec 13, 2023
| @@ -18,6 +18,7 @@ rustc --version | |||
|
|
|||
| banner check | |||
| ptime -m cargo check --features falcon | |||
| ptime -m cargo xtask clippy | |||
There was a problem hiding this comment.
Probably just scope this to a cargo clippy ---features falcon? We don't need to run the non-falcon checks.
There was a problem hiding this comment.
done, also with --all-targets flag
xtask/src/task_clippy.rs
Outdated
Comment on lines
42
to
52
| #[cfg(target_os = "illumos")] | ||
| { | ||
| failed |= run_clippy(&[ | ||
| "--features", | ||
| "falcon", | ||
| "-p", | ||
| "propolis-server", | ||
| "-p", | ||
| "propolis-client", | ||
| ])?; | ||
| } |
There was a problem hiding this comment.
I believe this part of the change can be elided now that oxidecomputer/netadm-sys@d44d9e0 has landed? (Provided a cargo update -p libnet is done)
pfmooney
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
holding in draft until softnpu changes land