Modernize 16550 UART #574
Merged
Modernize 16550 UART #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I decided to do some of this clean-up while investigating Ry's UART bug. |
jordanhendricks
approved these changes
Dec 7, 2023
The 16550 emulation was one of the first bits of emulation sketched out in propolis, and it shows. While there is more work to be done in improving the fidelity of emulation, the use of bitflags and the like should make this more readable.
pfmooney
force-pushed
the
uart-update
branch
from
70060ee to
0f7a50a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 16550 emulation was one of the first bits of emulation sketched out in propolis, and it shows. While there is more work to be done in improving the fidelity of emulation, the use of bitflags and the like should make this more readable.