Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure exitcode for reboot/halt on standalone #558

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Configure exitcode for reboot/halt on standalone #558

merged 1 commit into from
Oct 30, 2023
+38 −5

Conversation

pfmooney
Copy link
Collaborator

Fixes #557

@pfmooney pfmooney requested a review from jclulow October 30, 2023 04:48
jclulow
jclulow reviewed Oct 30, 2023
View reviewed changes
Copy link
Contributor

@jclulow jclulow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this so quickly! I have a couple of small questions.

bin/propolis-standalone/src/main.rs Outdated Show resolved Hide resolved
bin/propolis-standalone/src/main.rs Show resolved Hide resolved
@pfmooney pfmooney force-pushed the standalone-switches branch from e2d5c6c to ba4839f Compare October 30, 2023 16:25
jclulow
jclulow approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@jclulow jclulow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh! TIL ExitCode. Neat!

@pfmooney pfmooney merged commit ba4839f into oxidecomputer:master Oct 30, 2023
10 checks passed
@pfmooney pfmooney deleted the standalone-switches branch October 30, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jclulow jclulow jclulow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

standalone: option for process exit on guest reboot with stable exit status
2 participants
@pfmooney @jclulow