Split out mock propolis-server from real thing #556
Conversation
The simulated sled-agent in Omicron uses the Propolis mock server as a stand-in for a real VM instance. In order to break an awkward dependencies situation, it would be nice if the mock server did not haul in all everything which propolis-server requires. Fixes oxidecomputer#553
There was a problem hiding this comment.
If rust-analyzer is giving me an accurate picture of who's using things in this module, I would just drop it entirely: the only reason you need ServerSpecBuilderError is to serve as the return type to slot_to_pci_path, and in the mock, none of that function's callers actually care what error variant they got or about emitting their own ServerSpecBuilderError to a caller. So I'd just copy slot_to_pci_path to lib.rs, change its error type, and call it a day.
There was a problem hiding this comment.
If you're alright with that change being slightly delayed, my follow-on for this does clean up that error case.
There was a problem hiding this comment.
I think I'm suggesting something more radical than what's in 4919115: not only can we drop the InnerBuilderError variant from mock_server::copied::ServerSpecBuilderError, I suspect we can get rid of the entire enum and just have mock_server::copied::slot_to_pci_path return some other error type for its Err variant (at which point I'd probably just get rid of the copied module entirely and just move the private copy of slot_to_pci_path to the lib).
All that said, this is just cleanup and aesthetics, no need to hold this particular PR for it.
There was a problem hiding this comment.
If you're happy with clean-up like that happening later, then I'm inclined to move forward with things as-is.
There was a problem hiding this comment.
Yep, we can tackle that in a later PR.
The simulated sled-agent in Omicron uses the Propolis mock server as a stand-in for a real VM instance. In order to break an awkward dependencies situation, it would be nice if the mock server did not haul in all everything which propolis-server requires.
Fixes #553