Revert abort-on-panic in 'dev' cargo profile #527
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjcolombo
approved these changes
Sep 21, 2023
Since proper unwinding is required for handling `should_panic` tests cases, the existing default of abort-on-panic was rather inconvenient. This returns the 'dev' profile to using unwind-on-panic, and cleans up the 'phd' profile, which can use 'dev' as well for its unwinding.
pfmooney
force-pushed
the
build-profiles
branch
from
db2fd9d to
39191db
Compare
|
Merged in 6d815bb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since proper unwinding is required for handling
should_panictests cases, the existing default of abort-on-panic was rather inconvenient. This returns the 'dev' profile to using unwind-on-panic, and cleans up the 'phd' profile, which can use 'dev' as well for its unwinding.