Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sled agent] Remove enum bodies from support bundle API #7259

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

smklein
Copy link
Collaborator

@smklein smklein commented Dec 16, 2024

Responding to feedback in #7008 (comment) , this PR aligns the Sled Agent Support Bundle API with the incoming Nexus Support Bundle API (in #7008)

@@ -438,10 +438,9 @@ impl SledAgentApi for SledAgentSimImpl {
))
}

async fn support_bundle_get(
async fn support_bundle_download(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm re-working the simulated API in #7063 -- this is mostly a placeholder for now

@smklein smklein merged commit bb0b172 into main Dec 17, 2024
17 checks passed
@smklein smklein deleted the support-bundle-enum-cleanup branch December 17, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants