Refresh oximeter producer list more aggressively
#6926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove `oximeter` producer HTTP endpoint for registering individual producers. - Dramatically reduce interval on which `oximeter` collector refreshes its list of producers. This is now the only way the collector learns of producers. The interval is also much smaller in tests to ensure pretty snappy registrations - Remove calls from both Nexus and the `oximeter` standalone mock Nexus for registering producers - Have `oximeter` collector start polling producers immediately, rather than waiting for the first polling interval to expire. - Closes #6916, #6895, and #6901
jgallagher
approved these changes
Oct 24, 2024
Lots of tests use `force_collect()` to wait for oximeter to collect from themselves, before asserting things about the metrics. That no longer works, since the producer isn't registered right away. Now, use `wait_for_producer()` in tests to first wait for oximeter to notice the registration, and then continue as usual.
This was referenced Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oximeterproducer HTTP endpoint for registering individual producers.oximetercollector refreshes its list of producers. This is now the only way the collector learns of producers. The interval is also much smaller in tests to ensure pretty snappy registrationsoximeterstandalone mock Nexus for registering producersoximetercollector start polling producers immediately, rather than waiting for the first polling interval to expire.oximetershould refresh its producer list more frequently #6916, test failed in CI: integration_tests::metrics::test_metrics #6895, and test failed in CI: test_oximeter_reregistration #6901