Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use TestDatabase outside of nexus-db-queries too #6893

Merged
merged 34 commits into from
Oct 30, 2024
Merged

Use TestDatabase outside of nexus-db-queries too #6893

merged 34 commits into from
Oct 30, 2024

Conversation

smklein
Copy link
Collaborator

@smklein smklein commented Oct 17, 2024

As a follow-up to #6881 , refactors the TestDatabase logic within nexus_db_queries to be usable outside the crate too, if the testing feature is enabled.

smklein added 18 commits October 15, 2024 12:34
@smklein smklein mentioned this pull request Oct 17, 2024
Merged
Base automatically changed from qorb-terminate to main October 18, 2024 23:12
@smklein smklein marked this pull request as ready for review October 18, 2024 23:21
@smklein smklein requested a review from sunshowers October 21, 2024 16:02
@smklein smklein requested a review from hawkw October 28, 2024 22:00
hawkw
hawkw approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took me so long to take a look at this one, but it seems good to me! I had some kinda goofy nitpicks on the test APIs, but no real concerns.

nexus/db-queries/src/db/pub_test_utils/mod.rs Show resolved Hide resolved
nexus/db-queries/src/db/pub_test_utils/mod.rs Outdated Show resolved Hide resolved
nexus/db-queries/src/db/pub_test_utils/mod.rs Outdated Show resolved Hide resolved
nexus/db-queries/src/db/pub_test_utils/mod.rs Outdated Show resolved Hide resolved
@smklein smklein merged commit a866b20 into main Oct 30, 2024
17 checks passed
@smklein smklein deleted the more-test-database branch October 30, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkw hawkw hawkw approved these changes

@sunshowers sunshowers Awaiting requested review from sunshowers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smklein @hawkw