-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sled-agent] Support bundle storage api #6782
Conversation
/// Accesses the [SupportBundleManager] API. | ||
pub(crate) fn as_support_bundle_storage(&self) -> SupportBundleManager<'_> { | ||
SupportBundleManager::new(&self.log, self.storage()) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than directly implementing the support bundle API as part of the Sled Agent, I split it into a different structure to make testing easier.
That's why I'm calling this function in the http_entrypoints
// License, v. 2.0. If a copy of the MPL was not distributed with this | ||
// file, You can obtain one at https://mozilla.org/MPL/2.0/. | ||
|
||
pub mod queries; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI @papertigers - we both used the support_bundle.rs
module, so I split your stuff into "queries" and my stuff into "storage". Hopefully the re-organization makes sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @smklein, just a few small suggestions from me.
This library is used as a part of #1599 , I'm pulling it out of #6782 to help make the diff smaller. This PR adds a `range-requests` crate for dropshot-based range requests. Heavily inspired by @jclulow 's work in https://github.com/oxidecomputer/buildomat/blob/main/download/src/lib.rs
Thanks for the feedback! All the responses to review comments should be contained within e1e185b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @smklein!
This PR implements raw bundle storage for support bundles.
In the future, I expect that Nexus will invoke these APIs to store and later access portions of storage bundles.
Fixes #1599