Tweak IP pool edit onSuccess logic

[david-crespo]

Followup for #2405 (comment), which I posted seconds after merge. I made the conditional narrower and added a comment.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
console	✅ Ready (Inspect)	Visit Preview	Sep 3, 2024 7:45pm

[david-crespo]

I found the if-else confusing because the onDismiss and navigate do exactly the same thing

[charliepark]

Ah, good point.

[david-crespo]

Another way of doing this that's worth considering would be to add the ability to invalidateQueries to invalidate more narrowly than an entire endpoint.

console/app/api/hooks.ts

Lines 243 to 253 in c648c44

	/**
	* Note that we only take a single argument, `method`, rather than allowing
	* the full query key `[query, params]` to be specified. This is to avoid
	* accidentally overspecifying and therefore failing to match the desired
	* query. The params argument can be added back in if we ever have a use case
	* for it.
	*
	* Passing no arguments will invalidate all queries.
	*/
	invalidateQueries: <M extends keyof A>(method?: M, filters?: InvalidateQueryFilters) =>
	queryClient.invalidateQueries(method ? { queryKey: [method], ...filters } : undefined),

So in this case we'd be able to avoid the conditional by invalidating the fetch under the old name, but not the new name. Working on a quick PR showing that option. I thought it was kind of dicey but it's not.

#2410

[charliepark]

As I mentioned in the other PR, I prefer (w/o strong feelings on it) the way you have it in this PR. But open to either direction.

[charliepark]

Cleaner. Also agree that updatedPool is clearer.