Add SSH info to Instance Connect tab #2339
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
We could maybe add one of the docs popup buttons to the top right of the SSH box to house the docs link, but I don't like how that'd add a whole new piece to that component. |
|
I'm fine with the docs link right in the text.
or whatever |
|
This styling is slightly confusing, as the SSH information section looks like a modal with no buttons. For the information banners, we should stick to consistently using the blue style like this:
|
|
What about the serial console one? It also is not a modal. I was thinking these two should be styled the same because they are two ways of connecting to the instances. We might have a third one for VNC soon. |
|
These are different components: the first one is a card (e.g., Card Component), and the second one is an alert / banner / (e.g., Alert Component). They serve different purposes and have different properties. Cards are used for grouping related content and actions, while alerts are used to call out user attention and provide contextual information. For example, we may actually put the banner / alert in the card itself if we need a better visual grouping. |
|
Current state: 
|
| <div className="flex gap-3">{children}</div> | ||
| </div> | ||
| ), | ||
| Footer: classed.div`flex items-center justify-between border-t px-6 py-3 border-default h-14`, |
There was a problem hiding this comment.
Classic easier-to-compose-at-the-call-site situation
|
This is close, but needs:
|
|
Current: |
Fixes #2271
This adds an informational box to the Connect tab, talking about SSH and how the user can connect with their instance.
If they've set up any external IPs, it gives them most of what they need, using one of their floating IPs (and falling back to an ephemeral IP if no floating IPs).
If they haven't set up any external IPs, it directs them to the networking tab to set one up.
Learn more links go to the new Remote Access guide: https://docs.oxide.computer/guides/remote-access