-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preview meta #1821
Preview meta #1821
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I can rm the image as part of the build step in CI, but it might not be worth doing. I’ll think about it. |
I was thinking what if we conditionally included the OG tag inside index.html and somehow referenced the image file in a way that it would be shaken out when the OG tag is not included. However:
Like I said I could rm it from the build tarball in the GH action that does it, but it's not a big deal. I'd rather just leave it. Though it occurs to me... what if we left in the OG tag in production with an appropriate description? |
My hesitation with that is that it's nice to preserve the idea that the rack is yours – part of the reason I've avoided too much branding on the console. If we were feeling fancy in the future we could use a templated design but |
oxidecomputer/console@ae8218d...1802c28 * [1802c285](oxidecomputer/console@1802c285) oxidecomputer/console#1839 * [ce09b547](oxidecomputer/console@ce09b547) bump postcss-pseudo-classes for fake vuln * [e09b803b](oxidecomputer/console@e09b803b) might as well get vitest 1.0 in there too * [83dd73ee](oxidecomputer/console@83dd73ee) minor bumps for react router, msw, vite, tailwind, recharts * [6ae6beeb](oxidecomputer/console@6ae6beeb) oxidecomputer/console#1829 * [a0bf47aa](oxidecomputer/console@a0bf47aa) oxidecomputer/console#1836 * [6c9420ad](oxidecomputer/console@6c9420ad) oxidecomputer/console#1835 * [64e97b01](oxidecomputer/console@64e97b01) api-diff also takes a commit * [22bef0bb](oxidecomputer/console@22bef0bb) oxidecomputer/console#1833 * [2fe50f51](oxidecomputer/console@2fe50f51) oxidecomputer/console#1810 * [faadb6d3](oxidecomputer/console@faadb6d3) oxidecomputer/console#1832 * [9e82f9ab](oxidecomputer/console@9e82f9ab) oxidecomputer/console#1811 * [5e11fd83](oxidecomputer/console@5e11fd83) tweak api-diff * [dae20577](oxidecomputer/console@dae20577) oxidecomputer/console#1827 * [ed0ef62e](oxidecomputer/console@ed0ef62e) minor tweaks to api-diff script * [1c790d27](oxidecomputer/console@1c790d27) oxidecomputer/console#1819 * [97be7724](oxidecomputer/console@97be7724) oxidecomputer/console#1826 * [87f4d8b8](oxidecomputer/console@87f4d8b8) oxidecomputer/console#1814 * [65ae1212](oxidecomputer/console@65ae1212) oxidecomputer/console#1820 * [5a6dcea7](oxidecomputer/console@5a6dcea7) oxidecomputer/console#1822 * [4e1bbe13](oxidecomputer/console@4e1bbe13) oxidecomputer/console#1821 * [17408f64](oxidecomputer/console@17408f64) oxidecomputer/console#1813
### User-facing changes * [1802c285](oxidecomputer/console@1802c285) oxidecomputer/console#1839 * [6ae6beeb](oxidecomputer/console@6ae6beeb) oxidecomputer/console#1829 * [a0bf47aa](oxidecomputer/console@a0bf47aa) oxidecomputer/console#1836 * [9e82f9ab](oxidecomputer/console@9e82f9ab) oxidecomputer/console#1811 * [5a6dcea7](oxidecomputer/console@5a6dcea7) oxidecomputer/console#1822 ### All changes oxidecomputer/console@ae8218d...1802c28 * [1802c285](oxidecomputer/console@1802c285) oxidecomputer/console#1839 * [ce09b547](oxidecomputer/console@ce09b547) bump postcss-pseudo-classes for fake vuln * [e09b803b](oxidecomputer/console@e09b803b) might as well get vitest 1.0 in there too * [83dd73ee](oxidecomputer/console@83dd73ee) minor bumps for react router, msw, vite, tailwind, recharts * [6ae6beeb](oxidecomputer/console@6ae6beeb) oxidecomputer/console#1829 * [a0bf47aa](oxidecomputer/console@a0bf47aa) oxidecomputer/console#1836 * [6c9420ad](oxidecomputer/console@6c9420ad) oxidecomputer/console#1835 * [64e97b01](oxidecomputer/console@64e97b01) api-diff also takes a commit * [22bef0bb](oxidecomputer/console@22bef0bb) oxidecomputer/console#1833 * [2fe50f51](oxidecomputer/console@2fe50f51) oxidecomputer/console#1810 * [faadb6d3](oxidecomputer/console@faadb6d3) oxidecomputer/console#1832 * [9e82f9ab](oxidecomputer/console@9e82f9ab) oxidecomputer/console#1811 * [5e11fd83](oxidecomputer/console@5e11fd83) tweak api-diff * [dae20577](oxidecomputer/console@dae20577) oxidecomputer/console#1827 * [ed0ef62e](oxidecomputer/console@ed0ef62e) minor tweaks to api-diff script * [1c790d27](oxidecomputer/console@1c790d27) oxidecomputer/console#1819 * [97be7724](oxidecomputer/console@97be7724) oxidecomputer/console#1826 * [87f4d8b8](oxidecomputer/console@87f4d8b8) oxidecomputer/console#1814 * [65ae1212](oxidecomputer/console@65ae1212) oxidecomputer/console#1820 * [5a6dcea7](oxidecomputer/console@5a6dcea7) oxidecomputer/console#1822 * [4e1bbe13](oxidecomputer/console@4e1bbe13) oxidecomputer/console#1821 * [17408f64](oxidecomputer/console@17408f64) oxidecomputer/console#1813
Adds an OG image that's included only on Vercel deployments:
One downside maybe someone can chip in on is you can't import images within the
vite.config
file. That means that the OG image is included in the public directory and therefore even if the meta data isn't included, the image itself it. Not a big deal (only 90kb) – but certainly neater if we can remove it as part of the build process.