Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display errors on instance actions #1806

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Conversation

david-crespo
Copy link
Collaborator

I have a messed up instance and all the actions 500. I noticed we don't say anything when these actions error. Now we do.

2023-10-31-instance-action-error-toast.mp4

Copy link

vercel bot commented Oct 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
console ✅ Ready (Inspect) Visit Preview Oct 31, 2023 4:24pm

@david-crespo david-crespo enabled auto-merge (squash) October 31, 2023 16:38
@david-crespo david-crespo merged commit 47d76db into main Oct 31, 2023
7 checks passed
@david-crespo david-crespo deleted the instance-action-errors branch October 31, 2023 16:39
david-crespo added a commit to oxidecomputer/omicron that referenced this pull request Nov 4, 2023
oxidecomputer/console@bd65b9d...ae8218d

* [ae8218df](oxidecomputer/console@ae8218df) bump msw to 2.0.3 for the real safari fix
* [9a3f95a9](oxidecomputer/console@9a3f95a9) reduce dev console noise about local assets not served by MSW
* [a61ecf24](oxidecomputer/console@a61ecf24) oxidecomputer/console#1809
* [50f3a5b2](oxidecomputer/console@50f3a5b2) bump recharts and react query
* [1a2b5656](oxidecomputer/console@1a2b5656) oxidecomputer/console#1808
* [4c01cd68](oxidecomputer/console@4c01cd68) oxidecomputer/console#1800
* [57cc1892](oxidecomputer/console@57cc1892) oxidecomputer/console#1802
* [47d76dbf](oxidecomputer/console@47d76dbf) oxidecomputer/console#1806
* [eee0eb2e](oxidecomputer/console@eee0eb2e) oxidecomputer/console#1805
* [60c2285e](oxidecomputer/console@60c2285e) oxidecomputer/console#1804
* [d9cf1ef1](oxidecomputer/console@d9cf1ef1) bump sort imports plugin for vuln
* [ba3a383e](oxidecomputer/console@ba3a383e) bump playwright to 1.39 (fix issue with z-index test)
david-crespo added a commit to oxidecomputer/omicron that referenced this pull request Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant