Delete button on silo images table #1797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
commented
Oct 19, 2023
| ra.resource_type === resourceType && | ||
| ra.resource_id === resourceId && | ||
| roleOrStronger[role].includes(ra.role_name) | ||
| ) |
There was a problem hiding this comment.
Honestly this was very easy. Not sure why I didn't do this before.
Well.... this does not account for parent-child relationships, like if you have collab on silo you also have it on all projects in silo. I need to either account for that or add a comment about the limitation.
Edit: Comment added in 771f5d7
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Oct 23, 2023
oxidecomputer/console@3538c32...672cb20 * [672cb208](oxidecomputer/console@672cb208) bump API spec (BGP endpoints, not used yet) * [a50777c5](oxidecomputer/console@a50777c5) oxidecomputer/console#1795 * [8978e07a](oxidecomputer/console@8978e07a) bump omicron version (no changes) * [992fb1e1](oxidecomputer/console@992fb1e1) oxidecomputer/console#1797 * [e5b8d029](oxidecomputer/console@e5b8d029) remove unnecessary @types/testing-library__jest-dom dep * [e9a78617](oxidecomputer/console@e9a78617) tanstack query 5 went stable
This was referenced Oct 23, 2023
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Oct 23, 2023
oxidecomputer/console@3538c32...8e74acc * [8e74accf](oxidecomputer/console@8e74accf) handle empty metrics list on silo utilization * [672cb208](oxidecomputer/console@672cb208) bump API spec (BGP endpoints, not used yet) * [a50777c5](oxidecomputer/console@a50777c5) oxidecomputer/console#1795 * [8978e07a](oxidecomputer/console@8978e07a) bump omicron version (no changes) * [992fb1e1](oxidecomputer/console@992fb1e1) oxidecomputer/console#1797 * [e5b8d029](oxidecomputer/console@e5b8d029) remove unnecessary @types/testing-library__jest-dom dep * [e9a78617](oxidecomputer/console@e9a78617) tanstack query 5 went stable
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Oct 23, 2023
oxidecomputer/console@3538c32...bd65b9d * [bd65b9da](oxidecomputer/console@bd65b9da) loading state for utilization table, use QueryParamTabs * [8e74accf](oxidecomputer/console@8e74accf) handle empty metrics list on silo utilization * [672cb208](oxidecomputer/console@672cb208) bump API spec (BGP endpoints, not used yet) * [a50777c5](oxidecomputer/console@a50777c5) oxidecomputer/console#1795 * [8978e07a](oxidecomputer/console@8978e07a) bump omicron version (no changes) * [992fb1e1](oxidecomputer/console@992fb1e1) oxidecomputer/console#1797 * [e5b8d029](oxidecomputer/console@e5b8d029) remove unnecessary @types/testing-library__jest-dom dep * [e9a78617](oxidecomputer/console@e9a78617) tanstack query 5 went stable
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Oct 23, 2023
oxidecomputer/console@3538c32...bd65b9d * [bd65b9da](oxidecomputer/console@bd65b9da) loading state for utilization table, use QueryParamTabs * [8e74accf](oxidecomputer/console@8e74accf) handle empty metrics list on silo utilization * [672cb208](oxidecomputer/console@672cb208) bump API spec (BGP endpoints, not used yet) * [a50777c5](oxidecomputer/console@a50777c5) oxidecomputer/console#1795 * [8978e07a](oxidecomputer/console@8978e07a) bump omicron version (no changes) * [992fb1e1](oxidecomputer/console@992fb1e1) oxidecomputer/console#1797 * [e5b8d029](oxidecomputer/console@e5b8d029) remove unnecessary @types/testing-library__jest-dom dep * [e9a78617](oxidecomputer/console@e9a78617) tanstack query 5 went stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1796
onErroron project image delete to fix double toast (delete confirm handles error toast for us)