-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Silo utilization table #1795
Merged
Merged
Silo utilization table #1795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This is looking pretty good. Couple of things I'm still thinking about:
|
Looks good, a couple of things that caught my attention:
It'd be great to address these for future improvements. |
# Conflicts: # app/test/e2e/utilization.e2e.ts
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Oct 23, 2023
oxidecomputer/console@3538c32...672cb20 * [672cb208](oxidecomputer/console@672cb208) bump API spec (BGP endpoints, not used yet) * [a50777c5](oxidecomputer/console@a50777c5) oxidecomputer/console#1795 * [8978e07a](oxidecomputer/console@8978e07a) bump omicron version (no changes) * [992fb1e1](oxidecomputer/console@992fb1e1) oxidecomputer/console#1797 * [e5b8d029](oxidecomputer/console@e5b8d029) remove unnecessary @types/testing-library__jest-dom dep * [e9a78617](oxidecomputer/console@e9a78617) tanstack query 5 went stable
This was referenced Oct 23, 2023
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Oct 23, 2023
oxidecomputer/console@3538c32...8e74acc * [8e74accf](oxidecomputer/console@8e74accf) handle empty metrics list on silo utilization * [672cb208](oxidecomputer/console@672cb208) bump API spec (BGP endpoints, not used yet) * [a50777c5](oxidecomputer/console@a50777c5) oxidecomputer/console#1795 * [8978e07a](oxidecomputer/console@8978e07a) bump omicron version (no changes) * [992fb1e1](oxidecomputer/console@992fb1e1) oxidecomputer/console#1797 * [e5b8d029](oxidecomputer/console@e5b8d029) remove unnecessary @types/testing-library__jest-dom dep * [e9a78617](oxidecomputer/console@e9a78617) tanstack query 5 went stable
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Oct 23, 2023
oxidecomputer/console@3538c32...bd65b9d * [bd65b9da](oxidecomputer/console@bd65b9da) loading state for utilization table, use QueryParamTabs * [8e74accf](oxidecomputer/console@8e74accf) handle empty metrics list on silo utilization * [672cb208](oxidecomputer/console@672cb208) bump API spec (BGP endpoints, not used yet) * [a50777c5](oxidecomputer/console@a50777c5) oxidecomputer/console#1795 * [8978e07a](oxidecomputer/console@8978e07a) bump omicron version (no changes) * [992fb1e1](oxidecomputer/console@992fb1e1) oxidecomputer/console#1797 * [e5b8d029](oxidecomputer/console@e5b8d029) remove unnecessary @types/testing-library__jest-dom dep * [e9a78617](oxidecomputer/console@e9a78617) tanstack query 5 went stable
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Oct 23, 2023
oxidecomputer/console@3538c32...bd65b9d * [bd65b9da](oxidecomputer/console@bd65b9da) loading state for utilization table, use QueryParamTabs * [8e74accf](oxidecomputer/console@8e74accf) handle empty metrics list on silo utilization * [672cb208](oxidecomputer/console@672cb208) bump API spec (BGP endpoints, not used yet) * [a50777c5](oxidecomputer/console@a50777c5) oxidecomputer/console#1795 * [8978e07a](oxidecomputer/console@8978e07a) bump omicron version (no changes) * [992fb1e1](oxidecomputer/console@992fb1e1) oxidecomputer/console#1797 * [e5b8d029](oxidecomputer/console@e5b8d029) remove unnecessary @types/testing-library__jest-dom dep * [e9a78617](oxidecomputer/console@e9a78617) tanstack query 5 went stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently a user can filter by silo to see its individual utilization. There presently is no real way to easily compare metrics across silos. This is partly due to the API not returning this aggregated data. In the short-term we can stub this out by batching a whole bunch of requests and constructing the table from the merged results – this might also give us some guidance on the shape of the API that we need.
We're working on an idealised design, including quotas – but the details of this are still being worked on, and this PR has the simplest implementation possible right now.
This adds a new hook
useApiQueries
which is our version ofuseQueries
, but with the key difference that all queries in a given call are using the same API method, and therefore all have the same request and response (Params
andResult
) types.