Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to @oxide/design-system icons #1765

Merged
merged 7 commits into from
Oct 4, 2023
Merged

Move to @oxide/design-system icons #1765

merged 7 commits into from
Oct 4, 2023

Conversation

benjaminleonard
Copy link
Contributor

The design system now exports icons in any format that a repo might use; React components, SVGs, spritesheet so we no longer need to have a build process within the console – and it benefits us to have a single source of truth so this PR imports from the design system instead.

The default index generator from SVGR exports an icon in the following format: export { default as Close8Icon } from './Close8Icon.tsx';. The type checker is displeased with this because it includes the file extension. The easiest solution is to set allowImportingTsExtensions to true in the tsConfig.

Also switching to the new metrics icon on the utilization pages. Fixes #1654

@vercel
Copy link

vercel bot commented Oct 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
console ✅ Ready (Inspect) Visit Preview Oct 4, 2023 4:24pm

@david-crespo
Copy link
Collaborator

Very cool, love to get these icons out of here. Seems like Vite is pissed off about the imports, though. Blank screen and

Uncaught ReferenceError: can't access lexical declaration 'Zr' before initialization

in console. When I click the sourcemap I see this in Message.tsx:

import { Error12Icon, Success12Icon, Warning12Icon } from '../../'

https://console-j93an1226-oxidecomputer.vercel.app/

@david-crespo
Copy link
Collaborator

david-crespo commented Oct 4, 2023

The error reproduces in local dev, so it should be pretty easy to figure out. I'll take a look.

Copy link
Collaborator

@david-crespo david-crespo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOODBYE CODE

@david-crespo david-crespo enabled auto-merge (squash) October 4, 2023 16:26
@david-crespo david-crespo merged commit 8c9513c into main Oct 4, 2023
7 checks passed
@david-crespo david-crespo deleted the ds-icons branch October 4, 2023 16:36
david-crespo added a commit to oxidecomputer/omicron that referenced this pull request Oct 4, 2023
oxidecomputer/console@af6536d...0cc1e03

* [0cc1e03a](oxidecomputer/console@0cc1e03a) oxidecomputer/console#1770
* [48aea2f4](oxidecomputer/console@48aea2f4) npm audit fix
* [84aff1de](oxidecomputer/console@84aff1de) oxidecomputer/console#1769
* [c127febd](oxidecomputer/console@c127febd) oxidecomputer/console#1768
* [8c9513c1](oxidecomputer/console@8c9513c1) oxidecomputer/console#1765
* [0314fd72](oxidecomputer/console@0314fd72) oxidecomputer/console#1742
* [8918ffa9](oxidecomputer/console@8918ffa9) skip the other flaky test in safari for now. I'm suffering
* [b357246e](oxidecomputer/console@b357246e) increase playwright total time to 20 minutes
* [4f7d401d](oxidecomputer/console@4f7d401d) be sneakier about PR numbers in commit messages in bump omicron PR
david-crespo added a commit to oxidecomputer/omicron that referenced this pull request Oct 4, 2023
The only functional change should be the form validation one. And one
icon. But there are some tweaks to our build setup that I'd like to make
sure we didn't mess up.

oxidecomputer/console@af6536d...0cc1e03

* [0cc1e03a](oxidecomputer/console@0cc1e03a)
oxidecomputer/console#1770
* [48aea2f4](oxidecomputer/console@48aea2f4)
npm audit fix
* [84aff1de](oxidecomputer/console@84aff1de)
oxidecomputer/console#1769
* [c127febd](oxidecomputer/console@c127febd)
oxidecomputer/console#1768
* [8c9513c1](oxidecomputer/console@8c9513c1)
oxidecomputer/console#1765
* [0314fd72](oxidecomputer/console@0314fd72)
oxidecomputer/console#1742
* [8918ffa9](oxidecomputer/console@8918ffa9)
skip the other flaky test in safari for now. I'm suffering
* [b357246e](oxidecomputer/console@b357246e)
increase playwright total time to 20 minutes
* [4f7d401d](oxidecomputer/console@4f7d401d)
be sneakier about PR numbers in commit messages in bump omicron PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metrics pages should use metrics icon in header and sidebar
2 participants