rename form to "View SSH key"

oxidecomputer · Dec 6, 2024 · b24533f · b24533f
1 parent eafdb46
commit b24533f
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/app/forms/ssh-key-edit.tsx b/app/forms/ssh-key-edit.tsx
@@ -33,8 +33,6 @@ export function EditSSHKeySideModalForm() {
   const navigate = useNavigate()
   const { sshKey } = useSshKeySelector()
 
-  const onDismiss = () => navigate(pb.sshKeys())
-
   const { data } = usePrefetchedApiQuery('currentUserSshKeyView', {
     path: { sshKey },
   })
@@ -46,7 +44,8 @@ export function EditSSHKeySideModalForm() {
       form={form}
       formType="edit"
       resourceName="SSH key"
-      onDismiss={onDismiss}
+      title="View SSH key"
+      onDismiss={() => navigate(pb.sshKeys())}
       subtitle={
         <ResourceLabel>
           <Key16Icon /> {data.name}

diff --git a/app/routes.tsx b/app/routes.tsx
@@ -124,7 +124,7 @@ export const routes = createRoutesFromElements(
               path=":sshKey/edit"
               loader={EditSSHKeySideModalForm.loader}
               element={<EditSSHKeySideModalForm />}
-              handle={titleCrumb('Edit SSH Key')}
+              handle={titleCrumb('View SSH Key')}
             />
           </Route>
           <Route path="ssh-keys-new" {...SSHKeyCreate} handle={titleCrumb('New SSH key')} />

diff --git a/test/e2e/ssh-keys.e2e.ts b/test/e2e/ssh-keys.e2e.ts
@@ -23,9 +23,8 @@ test('SSH keys', async ({ page }) => {
   await page.getByRole('link', { name: 'm1-macbook-pro' }).click()
 
   // verify side modal content
-  const modal = page.getByRole('dialog')
+  const modal = page.getByRole('dialog', { name: 'View SSH key' })
   await expect(modal).toBeVisible()
-  await expect(modal.getByText('Edit SSH key')).toBeVisible()
   await expect(modal.getByRole('heading', { name: 'm1-macbook-pro' })).toBeVisible()
 
   const propertiesTable = modal.locator('.properties-table')