Ensure min/max are piped through number field

oxidecomputer · Nov 30, 2023 · 6950ca1 · 6950ca1
1 parent cabea63
commit 6950ca1
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/app/components/form/fields/NumberField.tsx b/app/components/form/fields/NumberField.tsx
@@ -69,6 +69,8 @@ export const NumberFieldInner = <
   required,
   id: idProp,
   transform,
+  min,
+  max,
 }: TextFieldProps<number, TFieldValues, TName>) => {
   const generatedId = useId()
   const id = idProp || generatedId
@@ -90,6 +92,8 @@ export const NumberFieldInner = <
               aria-describedby={description ? `${id}-label-tip` : undefined}
               defaultValue={value}
               onChange={(v) => onChange(transform ? transform(v) : v)}
+              minValue={typeof min !== 'undefined' ? Number(min) : undefined}
+              maxValue={typeof max !== 'undefined' ? Number(max) : undefined}
               {...fieldRest}
             />
             <ErrorMessage error={error} label={label} />