update tests

oxidecomputer · Aug 19, 2024 · 1137eb5 · 1137eb5
1 parent 7e0174e
commit 1137eb5
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/test/e2e/firewall-rules.e2e.ts b/test/e2e/firewall-rules.e2e.ts
@@ -157,11 +157,17 @@ test('firewall rule form targets table', async ({ page }) => {
   await addButton.click()
   await expectRowVisible(targets, { Type: 'vpc', Value: 'def' })
 
+  // select the target type as VPC Subnet
   await page.getByRole('button', { name: 'Target type' }).click()
   await page.getByRole('option', { name: 'VPC Subnet' }).click()
-  await page.getByRole('textbox', { name: 'Subnet name' }).fill('abc')
+  // select the VPC
+  await page.getByLabel('VPC', { exact: true }).nth(0).click()
+  await page.getByRole('option', { name: 'mock-vpc' }).click()
+  // select the subnet
+  await page.getByRole('combobox', { name: 'Subnet name' }).nth(0).click()
+  await page.getByRole('option', { name: 'mock-subnet' }).click()
   await addButton.click()
-  await expectRowVisible(targets, { Type: 'subnet', Value: 'abc' })
+  await expectRowVisible(targets, { Type: 'subnet', Value: 'mock-subnet' })
 
   await page.getByRole('button', { name: 'Target type' }).click()
   await page.getByRole('option', { name: 'IP', exact: true }).click()