Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a 'connection killer' to help make transactions panic & cancel-safe #81

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

smklein
Copy link
Collaborator

@smklein smklein commented Oct 24, 2024

Adds (and uses) a ConnectionKiller, which marks a connection as dead if it is synchronously dropped, even from
an asynchronous context. This ensures connections used by transactions are marked "unusable" if the transaction is cancelled and dropped.

Fixes #47

src/async_traits.rs Outdated Show resolved Hide resolved
src/async_traits.rs Show resolved Hide resolved
@smklein smklein requested a review from davepacheco October 28, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

transaction_async is not cancel-safe or panic-safe, and bedlam ensues
2 participants