Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in the tests for Problem 87 #74

Merged
merged 1 commit into from
Jan 29, 2023

Conversation

seanstrom
Copy link
Contributor

Hey 👋,
Just wanted to fix the tests as described in issue #66

Hope this helps, and let me know if I need to make more changes. Thank you!

@seanstrom seanstrom force-pushed the seanstrom/fix-problem-87-tests branch from bc93e3b to 7cf89e4 Compare January 5, 2023 10:28
@oxalorg
Copy link
Owner

oxalorg commented Jan 28, 2023

@seanstrom Thanks for the PR, super appreciate it. Do you have a solution for this problem that works with this PR change?

@seanstrom
Copy link
Contributor Author

Hey @oxalorg 👋, I'm happy to help 😸
And yup I have a solution that I tested on my branch.
Here's a link to a gist of the code

@oxalorg oxalorg merged commit 5489c58 into oxalorg:main Jan 29, 2023
@oxalorg
Copy link
Owner

oxalorg commented Jan 29, 2023

@seanstrom Thanks a lot for the fix and solution! LGTM 🥳

@seanstrom seanstrom deleted the seanstrom/fix-problem-87-tests branch January 29, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants