cors support in remote #99
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 21, 2023 16:48
version of fastify kenku uses) to allow CORS requests to support browser requests, e.g. owlbear2 extensions
|
That enabled GET, but it appears preflight is required for PUT and POST, so this is not complete |
|
Updated with commit works for get and put requests to develop playlist extension |
|
Is there anything hold back this PR being merged? I would also like to be able to control kenk.fm from within other software |
|
Capacity of the (two) OBR devs is a limitation, and the focus right now is on the next major release of Owlbear Rodeo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While developing an Owlbear2 extension to interface with Kenku, I noticed requests are blocked due to CORS limitations. This PR uses the version of fastify-cors compatible with kenku's version of fastify to add an Access-Control-Allowed-Header, e.g. from my Owlbear 2 extension running on 5173, the response headers are:
HTTP/1.1 200 OK
vary: Origin
access-control-allow-origin: http://localhost:5173
content-type: application/json; charset=utf-8
content-length: 341
Date: Sun, 21 May 2023 20:56:45 GMT
Connection: keep-alive
Keep-Alive: timeout=5