Fix DispatchAudit Serialization Problems #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjawad096
suggested changes
Dec 29, 2023
|
I think we should also have a test failing before the patch to ensure it really is fixed and never happening again. |
mjawad096
approved these changes
Dec 29, 2023
|
@cangelis test added, but i don't use sanctum, was the |
This was referenced Dec 30, 2023
MortenDHansen
approved these changes
Apr 22, 2024
parallels999
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestingSerializesModelsSerializesModelswas unnecessaryCloses #892
Closes #891
Closes #890
Closes #895
Closes #885
I think this complicates things quite a bit.