Refactor auditSync, auditDetach, auditAttach methods #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikn69
force-pushed
the
patch-18
branch
3 times, most recently
from
41d9691 to
0a80c2f
Compare
erikn69
changed the title
MortenDHansen
approved these changes
Oct 6, 2023
|
Looks about right. :) |
parallels999
approved these changes
Oct 6, 2023
Ok, I will wait for it to be merged to add another PR and discuss the new functionality, I don't like refactoring something and adding features at the same time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR keeps the current functionality, just better readability, PhpDoc fixes
@MortenDHansen Hi,
I want to make a change in the auditing of these relationship methods, I added
Collection::diffo my local copy, so that only theadded/removedrecords in the pivot are audited, and in the case that there are no changes and'audit.empty_values'is false the audit would not be recordedThat change depends on this being accepted.