Reverse prune query optimization

owen-it · Jun 26, 2024 · db5ed9c · db5ed9c
1 parent 783f824
commit db5ed9c
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/src/Drivers/Database.php b/src/Drivers/Database.php
@@ -25,11 +25,15 @@ public function prune(Auditable $model): bool
         if (($threshold = $model->getAuditThreshold()) > 0) {
             $class = get_class($model->audits()->getModel());
             $keyName = (new $class)->getKeyName();
-
+
+            $idsToKeep = $model->audits()
+                ->select($keyName)
+                ->limit($threshold)
+                ->latest()
+                ->pluck($keyName);
+
             return $model->audits()
-                ->whereNotIn(
-                    $keyName, $model->audits()->select($keyName)->limit($threshold)->latest()
-                )
+                ->whereNotIn($keyName, $idsToKeep)
                 ->delete() > 0;
         }