Let user handle connection errors #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shmish111
force-pushed
the
let-user-handle-connection-errors
branch
from
7f8509c to
420267c
Compare
|
Thanks. I'll prepare a new release for you now. 👍 |
owainlewis
added a commit
that referenced
this pull request
Oct 30, 2015
Let user handle connection errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #28
I also saw that errors while reading a message won't be recorded,
nilis returned for each field and there will be no overallException. I thought it's better to make sure all errors are recorded in an:errorsfield whilst still populating all the fields possible.