forked from PHP-DI/PHP-DI
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[php-di v7] DefinitionGlob #18
Open
partikus
wants to merge
9
commits into
mod7
Choose a base branch
from
feature/php-di-7-definition-glob
base: mod7
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
partikus
force-pushed
the
feature/php-di-7-definition-glob
branch
from
January 13, 2023 15:56
57ce38a
to
5dbcebe
Compare
partikus
force-pushed
the
feature/php-di-7-definition-glob
branch
2 times, most recently
from
January 10, 2024 07:47
7cf29d1
to
ce2fca8
Compare
partikus
force-pushed
the
feature/php-di-7-definition-glob
branch
from
January 10, 2024 08:40
ce2fca8
to
796ed99
Compare
1. Detected deprecations in use: - Rule "braces" is deprecated. Use "single_space_around_construct", "control_structure_braces", "control_structure_continuation_position", "declare_parentheses", "no_multiple_statements_per_line", "curly_braces_position", "statement_indentation" and "no_extra_blank_lines" instead. 2. Detected deprecations in use: - Rule "curly_braces_position" is deprecated. Use "braces_position" instead.
partikus
force-pushed
the
feature/php-di-7-definition-glob
branch
2 times, most recently
from
January 10, 2024 12:55
04d0ab7
to
772584d
Compare
falkenhawk
approved these changes
Jan 10, 2024
…ions feat: php-cs-fixer - removing deprecations
- there might be multiple definitions files scattered around in a modularized architecture - instead of listing all the files upfront, specify a glob pattern where to look for the files - directories would be scanned and files read lazily, when a definition is actually requested - to avoid performance hit on init
partikus
force-pushed
the
feature/php-di-7-definition-glob
branch
from
January 11, 2024 11:07
772584d
to
e6fdfde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version compatible with PHP ^8.0 as a successor of #2
Details (copied from #2)
DefinitionGlob to specify a pattern for definition files