ARC-1217: GesundheitsID Simple Test Flow #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasrichner-oviva
requested a review
from michelealbanese-oviva
as a code owner
michelealbanese-oviva
approved these changes
Feb 1, 2024
README.md
Outdated
| # Keycloak Identity Provider for GesundheitsID (eHealthID) | ||
|
|
||
| ## Contents | ||
| - [gesundheitsid](./gesundheitsid) - A plain Java library to build RelyingParties for GesundheitsID with. |
There was a problem hiding this comment.
Suggested change
| - [gesundheitsid](./gesundheitsid) - A plain Java library to build RelyingParties for GesundheitsID with. | |
| - [gesundheitsid](./gesundheitsid) - A plain Java library to build RelyingParties for GesundheitsID. |
README.md
Outdated
|
|
||
| ### Gematik Test Sektoraler IdP in Browser | ||
|
|
||
| Since the Gematik Referenze IDP in the Test Environment needs a custom header, it can not be used directly in the browser for authentication. |
There was a problem hiding this comment.
Suggested change
| Since the Gematik Referenze IDP in the Test Environment needs a custom header, it can not be used directly in the browser for authentication. | |
| Since the Gematik Reference IDP in the Test Environment needs a custom header, it can not be used directly in the browser for authentication. |
| "entity statement of '%s' has no authorization url configuration".formatted(sub)); | ||
| } | ||
|
|
||
| public static RuntimeException missingPARUrl(String sub) { |
There was a problem hiding this comment.
Suggested change
| public static RuntimeException missingPARUrl(String sub) { | |
| public static RuntimeException missingParUrl(String sub) { |
inconsistent casing (see invalidParRequestUri)
| @JsonProperty("urn:telematik:claims:profession") String telematikProfession, | ||
| @JsonProperty("urn:telematik:claims:given_name") String telematikGivenName, | ||
|
|
||
| /** vor insured person (IP) the immutable part of the Krankenversichertennummer (KVNR) * */ |
There was a problem hiding this comment.
Suggested change
| /** vor insured person (IP) the immutable part of the Krankenversichertennummer (KVNR) * */ | |
| /** for insured person (IP) the immutable part of the Krankenversichertennummer (KVNR) * */ |
| } | ||
|
|
||
| public Builder requirePushedAuthorizationRequests( | ||
| Boolean requirePushedAuthorizationRequests) { |
There was a problem hiding this comment.
Suggested change
| Boolean requirePushedAuthorizationRequests) { | |
| boolean requirePushedAuthorizationRequests) { |
There was a problem hiding this comment.
No, that's an optional field :)
|
michelealbanese-oviva
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.