feat: add option to wait for a specific port open #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
speed47
force-pushed
the
add_wait_port_option
branch
from
d413f9c
to
40064b3
Compare
speed47
added
tests:full
speed47
force-pushed
the
add_wait_port_option
branch
from
40064b3
to
bede25c
Compare
deathiop
previously approved these changes
Apr 8, 2024
speed47
force-pushed
the
add_wait_port_option
branch
3 times, most recently
from
8162b8e
to
d37eafe
Compare
deathiop
reviewed
Apr 9, 2024
speed47
force-pushed
the
add_wait_port_option
branch
from
d37eafe
to
2770f39
Compare
speed47
force-pushed
the
add_wait_port_option
branch
from
2770f39
to
e3e4c55
Compare
deathiop
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option introduce a wait for an open port instead of a simple ping. Sometimes it takes a very long time between the ping and the ssh access.