Adding ### section heading handling for XML output; adding regression tests #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the simplest of the approaches I outlines in issue #27. To make sure I haven't broken any of the other outputs, I added regression tests (in a separate commit). I simply took the .fountain files from https://github.com/nyousefi/Fountain/tree/master/FountainTests and ran textplay on them three times to generate HTML, XML and FDX outputs. The relevant files in the tests directory simply record texplay behavior as it is today. Running
make testsreports any differences between between current texplay output and previously recorded output.This is only a proposal. Let me know what you think, and what improvements I can male.