chore: update CSRF_TRUSTED_ORIGINS for Django 4.2 #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Sokolski <[email protected]>
regisb
approved these changes
Oct 30, 2023
There was a problem hiding this comment.
Thanks for your help Max! FTR I think edx-platform should not be waiting for the Tutor changes to be merged. Otherwise we have a cyclic chicken-and-egg problem for every PR. The upstream project is edx-platform, and Tutor depends on it, so changes should happen first in edx-platform.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are going to upgrade to Django 4.2 for Quince.
Issue: openedx/wg-build-test-release#315
PR to edx-platform: openedx/edx-platform#33516 (will be merged only after Tutor preparation for Django4.2)
Notes about Django4.2 schema changes for CSRF_TRUSTED_ORIGINS.
This PR has been testing for Django 3.2 as well.