chore: revert change that skip arm64 image build #48
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- As didkit issue is resolved in latest version which is being used in upstream credential repo. So, reverting this change. for context, see this comment: #34 (comment)
changelog.d/20241022_124256_faraz.maqsood_revert_arm64_build_skip_change_in_redwood.md
Outdated
Show resolved
Hide resolved
DawoudSheraz
approved these changes
Oct 22, 2024
|
Please add PR description and the link to nightly PR. |
Faraz32123
force-pushed
the
chore/revert_arm64_build_skip_change_in_redwood
branch
from
f81fcce to
91d56b3
Compare
Faraz32123
deleted the
chore/revert_arm64_build_skip_change_in_redwood
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR,
IMAGES_BUILD_PLATFORMsetting is removed. This setting was initially added to prevent the credentials image from being built forarm64due to issues with the didkit package onarm64machines. Now, the image can be built for both amd64 and arm64 architectures.This commit is already merged in nightly in this PR for sumac.
And this PR is made for redwood. Once redwood.3 is available, this PR will be merged.