Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows): fix a few more tests #8644

Merged
merged 17 commits into from
Feb 3, 2024
Merged

fix(windows): fix a few more tests #8644

merged 17 commits into from
Feb 3, 2024

Conversation

dylan-conway
Copy link
Member

What does this PR do?

fixes:

  • filesystem_router.test.ts
  • remaining node-module-module.test.js tests
  • edge case in normalizeStringGenericT and windowsFilesystemRootT
  • fs.test.ts bigintstats test
  • enables runtime transpiler on windows but not actually sure if it's fixed
  • cleans up a few tests to work on windows
  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

manually tested

Copy link
Contributor

github-actions bot commented Feb 2, 2024

Copy link
Contributor

github-actions bot commented Feb 2, 2024

Copy link
Contributor

github-actions bot commented Feb 2, 2024

Copy link
Contributor

github-actions bot commented Feb 2, 2024

Copy link
Contributor

github-actions bot commented Feb 2, 2024

❌🪟 @paperdave, there are 10 test regressions on Windows x86_64

  • test\bundler\cli.test.ts
  • test\bundler\esbuild\loader.test.ts
  • test\cli\run\transpiler-cache.test.ts
  • test\js\bun\console\console-iterator.test.ts
  • test\js\bun\util\bun-file-windows.test.ts
  • test\js\node\http\node-http.test.ts
  • test\js\node\module\node-module-module.test.js
  • test\js\node\process\process-args.test.js
  • test\regression\issue\08095.test.ts
  • test\transpiler\template-literal.test.ts

Full Test Output

@Jarred-Sumner Jarred-Sumner merged commit 5934b17 into main Feb 3, 2024
26 of 31 checks passed
@Jarred-Sumner Jarred-Sumner deleted the dylan/fix-more-tests branch February 3, 2024 02:58
Hanaasagi pushed a commit to Hanaasagi/bun that referenced this pull request Feb 3, 2024
* fix regression tests

* fix fs.test.ts bigintstats

* enable transpiler cache lol

* remove failing

* fix filesystem router

* update

* fix run-unicode test

* update comment

* add updated snapshot

* fix remaining node-module-module tests

* fixup

* [autofix.ci] apply automated fixes

* fix tty tests

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants