New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

windows: fix module.paths getter causing a crash #8633

Merged

Jarred-Sumner merged 3 commits into main from nektro-patch-464

Feb 2, 2024

+9 −12

Member

nektro commented Feb 2, 2024

ideally I'd like to add a test for this but it returns absolute paths


          windows: fix module.paths getter causing a crash

dfcdbff

Jarred-Sumner reviewed

View reviewed changes

src/resolver/resolver.zig Outdated Show resolved Hide resolved


          use the buffer that was there before

d05cd6a

nektro force-pushed the nektro-patch-464 branch from e602218 to d05cd6a Compare

February 2, 2024 03:36


          Merge branch 'main' into nektro-patch-464

1467c6f

Contributor

github-actions bot commented Feb 2, 2024

❌ @nektro 3 files with test failures on bun-darwin-aarch64:

test/cli/test/bun-test.test.ts 2 failing
test/js/bun/util/inspect-error.test.js 2 failing
test/js/third_party/webpack/webpack.test.ts 1 failing

View test output

^{#8adbc49c53857928a10acd7bb077823759c600db}

Contributor

github-actions bot commented Feb 2, 2024

❌ @nektro 4 files with test failures on linux-x64:

test/cli/test/bun-test.test.ts 1 failing
test/integration/next/default-pages-dir/test/next-build.test.ts 1 failing
test/js/bun/util/inspect-error.test.js 2 failing
test/js/third_party/webpack/webpack.test.ts 1 failing

View test output

^{#8adbc49c53857928a10acd7bb077823759c600db}

Contributor

github-actions bot commented Feb 2, 2024

❌ @nektro 4 files with test failures on linux-x64-baseline:

test/cli/test/bun-test.test.ts 1 failing
test/integration/next/default-pages-dir/test/next-build.test.ts 1 failing
test/js/bun/util/inspect-error.test.js 2 failing
test/js/third_party/webpack/webpack.test.ts 1 failing

View test output

^{#8adbc49c53857928a10acd7bb077823759c600db}

Contributor

github-actions bot commented Feb 2, 2024

❌ @nektro 5 files with test failures on bun-darwin-x64:

test/js/bun/util/inspect-error.test.js 2 failing
test/js/bun/util/which.test.ts 1 failing
test/js/node/fs/fs.test.ts 1 failing
test/js/node/watch/fs.watchFile.test.ts 1 failing
test/js/third_party/webpack/webpack.test.ts 1 failing

View test output

^{#8adbc49c53857928a10acd7bb077823759c600db}

Contributor

github-actions bot commented Feb 2, 2024 •

edited

Loading

❌🪟 @nektro, there are 11 test regressions on Windows x86_64

test\bundler\cli.test.ts
test\cli\inspect\inspect.test.ts
test\cli\run\transpiler-cache.test.ts
test\js\bun\console\console-iterator.test.ts
test\js\bun\util\bun-file-windows.test.ts
test\js\bun\util\inspect-error.test.js
test\js\node\http\node-http.test.ts
test\js\node\process\process-args.test.js
test\js\node\worker_threads\worker_threads.test.ts
test\regression\issue\08095.test.ts
test\transpiler\template-literal.test.ts

Full Test Output

Jarred-Sumner merged commit 3a6318b into main

26 of 31 checks passed

Jarred-Sumner deleted the nektro-patch-464 branch

February 2, 2024 09:29

Hanaasagi pushed a commit to Hanaasagi/bun that referenced this pull request


          windows: fix module.paths getter causing a crash (oven-sh#8633)

02f676b

* windows: fix module.paths getter causing a crash

* use the buffer that was there before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet