Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows): initialize uv allocators earlier #8631

Merged
merged 5 commits into from
Feb 2, 2024

Conversation

paperdave
Copy link
Member

We can merge this now, or we can wait for me to finish the worker test fixes.

Copy link
Collaborator

@Jarred-Sumner Jarred-Sumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't compile on posix

Copy link
Contributor

github-actions bot commented Feb 2, 2024

Copy link
Contributor

github-actions bot commented Feb 2, 2024

Copy link
Contributor

github-actions bot commented Feb 2, 2024

Copy link
Contributor

github-actions bot commented Feb 2, 2024

❌🪟 @Jarred-Sumner, there are 10 test regressions on Windows x86_64

  • test\bundler\cli.test.ts
  • test\bundler\esbuild\loader.test.ts
  • test\cli\run\transpiler-cache.test.ts
  • test\js\bun\console\console-iterator.test.ts
  • test\js\bun\util\bun-file-windows.test.ts
  • test\js\bun\util\inspect-error.test.js
  • test\js\node\http\node-http.test.ts
  • test\js\node\process\process-args.test.js
  • test\regression\issue\08095.test.ts
  • test\transpiler\template-literal.test.ts

Full Test Output

@Jarred-Sumner Jarred-Sumner merged commit 647b15e into main Feb 2, 2024
26 of 31 checks passed
@Jarred-Sumner Jarred-Sumner deleted the dave/threadlocal-uv-loop branch February 2, 2024 08:18
Hanaasagi pushed a commit to Hanaasagi/bun that referenced this pull request Feb 3, 2024
* uv loop is thread local

* hi

* stuff so far

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Jarred Sumner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants