Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UDP support #7271

Merged
merged 70 commits into from
Apr 26, 2024
Merged

UDP support #7271

merged 70 commits into from
Apr 26, 2024

Conversation

Electroid
Copy link
Contributor

@Electroid Electroid commented Nov 22, 2023

What does this PR do?

Issues

TODO

  • Diff needs to be cleaned up, since files in packages/bun-usockets were re-formatted.
  • Added support for $variable in test.each.
  • Fixed issue where Bun.spawn would remove empty arguments from cmd .
  • Update documentation for node:dgram
  • Update documentation for Bun's UDP API
  • Decide on final Bun API (still work-in-progress)

How did you verify your code works?

I wrote automated tests.

@Electroid Electroid marked this pull request as ready for review November 22, 2023 21:46
@Jarred-Sumner
Copy link
Collaborator

this doesn't implement dgram yet

Copy link
Contributor

github-actions bot commented Nov 22, 2023

@Electroid 5 files with test failures on bun-darwin-aarch64:

  • test/integration/next/default-pages-dir/test/dev-server.test.ts
  • test/integration/next/default-pages-dir/test/next-build.test.ts
  • test/js/bun/test/test-test.test.ts
  • test/js/bun/udp/udp.test.ts
  • test/js/bun/util/which.test.ts

View test output

#9cb7ee2130ac3c1b357d664bf359af709426935a

Copy link
Contributor

github-actions bot commented Nov 22, 2023

@Electroid 7 files with test failures on bun-darwin-x64-baseline:

  • test/js/bun/spawn/spawn-streaming-stdout.test.ts
  • test/js/bun/udp/udp.test.ts
  • test/js/bun/util/filesink.test.ts
  • test/js/bun/util/which.test.ts
  • test/js/node/fs/fs.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setTimeout.test.js

View test output

#9cb7ee2130ac3c1b357d664bf359af709426935a

Copy link
Contributor

github-actions bot commented Nov 23, 2023

@Electroid 2 files with test failures on linux-x64:

  • test/js/bun/udp/udp.test.ts
  • test/js/third_party/postgres/postgres.test.ts

View test output

#9cb7ee2130ac3c1b357d664bf359af709426935a

Copy link
Contributor

github-actions bot commented Nov 23, 2023

@Electroid 2 files with test failures on linux-x64-baseline:

  • test/js/bun/udp/udp.test.ts
  • test/js/third_party/postgres/postgres.test.ts

View test output

#9cb7ee2130ac3c1b357d664bf359af709426935a

Copy link
Contributor

@Electroid 8 files with test failures on bun-darwin-x64:

  • test/integration/next/default-pages-dir/test/next-build.test.ts
  • test/js/bun/spawn/spawn-streaming-stdout.test.ts
  • test/js/bun/udp/udp.test.ts
  • test/js/bun/util/which.test.ts
  • test/js/node/fs/fs.test.ts
  • test/js/node/watch/fs.watchFile.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setTimeout.test.js

View test output

#9cb7ee2130ac3c1b357d664bf359af709426935a

Copy link
Contributor

github-actions bot commented Apr 25, 2024

@gvilums, your commit has failing tests :(

💪 6 failing tests Darwin AARCH64

💻 2 failing tests Darwin x64 baseline

💻 2 failing tests Darwin x64

🐧💪 4 failing tests Linux AARCH64

🐧🖥 2 failing tests Linux x64 baseline

🐧🖥 1 failing tests Linux x64

🪟💻 11 failing tests Windows x64 baseline

🪟💻 10 failing tests Windows x64

View logs

@gvilums gvilums merged commit 589f941 into main Apr 26, 2024
29 of 30 checks passed
@gvilums gvilums deleted the udp branch April 26, 2024 22:25
@benjamingwynn
Copy link

For my own reference, advanced dgram methods are covered in issue #10381

@RadhiRasho
Copy link
Contributor

This might just be me, but it would seem like the bun-types changes never made it out/weren't bundled correctly. I've tried every way I can to get the latest and I'm on the latest version of Bun:
image

I've also set the version of the @types/bun package to be the latest and cleared the pm cache a few times using bun pm cache rm.

This is all in a simple bun init project and is easily reproducible.

@RadhiRasho
Copy link
Contributor

This might just be me, but it would seem like the bun-types changes never made it out/weren't bundled correctly. I've tried every way I can to get the latest and I'm on the latest version of Bun: image

I've also set the version of the @types/bun package to be the latest and cleared the pm cache a few times using bun pm cache rm.

This is all in a simple bun init project and is easily reproducible.

Ignore, seems to have been resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement $var interpolation in test.each Implement dgram
5 participants