New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the same hoisting logic for text lockfile #15778

Open

dylan-conway wants to merge 2 commits into main from dylan/hoist-text-lockfile

Member

dylan-conway commented Dec 15, 2024

What does this PR do?

Ensures packages are placed in their expected locations after reading from bun.lock.

How did you verify your code works?

Added a test

dylan-conway added 2 commits

December 15, 2024 00:41


          use existing hoist

3be87d6


          test

fa387ac

robobun commented Dec 15, 2024 •

edited

Loading

^{Updated 3:06 AM PT - Dec 15th, 2024}

❌ @dylan-conway, your commit fa387ac has 11 failures in #8017:

test/js/bun/http/serve.test.ts - 2 failing on 🍎 14 x64
test/js/bun/http/serve.test.ts - 2 failing on 🍎 13 x64
test/js/web/fetch/fetch.test.ts - timeout on 🐧 12 x64
test/integration/next-pages/test/next-build.test.ts - 1 failing on 🐧 3.20 x64-baseline
test/v8/v8.test.ts - 22 failing on 🐧 3.20 aarch64
test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64
test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64-baseline
test/cli/run/require-cache.test.ts - 1 failing on 🐧 24.04 aarch64
test/cli/run/require-cache.test.ts - 1 failing on 🐧 22.04 x64-baseline
test/cli/run/require-cache.test.ts - 1 failing on 🍎 14 x64
test/cli/run/require-cache.test.ts - 1 failing on 🍎 13 x64
test/js/node/test/parallel/test-http-no-content-length.js - code 1 on 🪟 2019 x64-baseline
test/js/bun/spawn/spawn.test.ts - timeout on 🪟 2019 x64-baseline
test/js/node/test/parallel/test-worker-process-exit-async-module.js - code 1 on 🐧 22.04 aarch64
test/js/node/test/parallel/test-worker-process-exit-async-module.js - code 1 on 🐧 24.04 aarch64
test/js/node/fs/fs.test.ts - timeout on 🪟 2019 x64-baseline
test/cli/install/registry/bun-install-registry.test.ts - 1 failing on 🪟 2019 x64-baseline
test/cli/install/registry/bun-install-registry.test.ts - 1 failing on 🐧 20.04 aarch64
test/cli/install/registry/bun-install-registry.test.ts - timeout on 🐧 3.20 x64-baseline
test/js/bun/http/serve-body-leak.test.ts - 1 failing on 🪟 2019 x64-baseline

🧪 try this PR locally:

bunx bun-pr 15778

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet